Subject: Re: [PATCH 05/10] nohz: New tick dependency mask
To: Frederic Weisbecker <fweisbec@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <1437669735-8786-1-git-send-email-fweisbec@gmail.com>
 <1437669735-8786-6-git-send-email-fweisbec@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, Rik van Riel <riel@redhat.com>
From: Chris Metcalf <cmetcalf@ezchip.com>
Message-ID: <55B26E07.1020005@ezchip.com>
Date: Fri, 24 Jul 2015 12:55:35 -0400
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1437669735-8786-6-git-send-email-fweisbec@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
VI1PR02MB0781: X-MS-Exchange-Organization-RulesExecuted
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2015 16:55:51.3552 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0781
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1598
Lines: 51

On 07/23/2015 12:42 PM, Frederic Weisbecker wrote:
> +unsigned long __tick_nohz_set_tick_dependency(enum tick_dependency_bit bit,
> +					      unsigned long *dep)
> +{
> +	unsigned long prev;
> +	unsigned long old = *dep;
> +	unsigned long mask = BIT_MASK(bit);
> +
> +	while ((prev = cmpxchg(dep, old, old | mask)) != old) {
> +		old = prev;
> +		cpu_relax();
> +	}
> +
> +	return prev;
> +}

Why not use set_bit() here?  It is suitably atomic.

> +		/*
> +		* We need the IPIs to be sent from sane process context.
> +		* The posix cpu timers are always set with irqs disabled.
> +		*/

The block comment indentation is not quite right here.

> +void tick_nohz_set_tick_dependency_cpu(enum tick_dependency_bit bit, int cpu)
> +{
> +	unsigned long prev;
> +	struct tick_sched *ts;
> +
> +	ts = per_cpu_ptr(&tick_cpu_sched, cpu);
> +
> +	prev = __tick_nohz_set_tick_dependency(bit, &ts->tick_dependency);
> +	if (!prev)
> +		tick_nohz_full_kick_cpu(cpu);
> +}

I could imagine arguments for a WARN_ON() if cpu == smp_processor_id() 
here, since then you should be using the _thiscpu() variant.
Or, you could transparently call the _thiscpu() variant in that case.
I think some comment explaining why the approach you chose is better
than those alternatives would be helpful here, perhaps.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/