Subject: Re: [PATCH 05/10] nohz: New tick dependency mask
To: Frederic Weisbecker <fweisbec@gmail.com>
References: <1437669735-8786-1-git-send-email-fweisbec@gmail.com>
 <1437669735-8786-6-git-send-email-fweisbec@gmail.com>
 <55B26E07.1020005@ezchip.com> <20150724171655.GA20925@lerouge>
CC: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, Rik van Riel <riel@redhat.com>
From: Chris Metcalf <cmetcalf@ezchip.com>
Message-ID: <55B2794A.8040707@ezchip.com>
Date: Fri, 24 Jul 2015 13:43:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150724171655.GA20925@lerouge>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
VI1PR02MB0781: X-MS-Exchange-Organization-RulesExecuted
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2015 17:44:00.7734 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0781
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1346
Lines: 38

On 07/24/2015 01:16 PM, Frederic Weisbecker wrote:
> On Fri, Jul 24, 2015 at 12:55:35PM -0400, Chris Metcalf wrote:
>> On 07/23/2015 12:42 PM, Frederic Weisbecker wrote:
>>> +unsigned long __tick_nohz_set_tick_dependency(enum tick_dependency_bit bit,
>>> +					      unsigned long *dep)
>>> +{
>>> +	unsigned long prev;
>>> +	unsigned long old = *dep;
>>> +	unsigned long mask = BIT_MASK(bit);
>>> +
>>> +	while ((prev = cmpxchg(dep, old, old | mask)) != old) {
>>> +		old = prev;
>>> +		cpu_relax();
>>> +	}
>>> +
>>> +	return prev;
>>> +}
>> Why not use set_bit() here?  It is suitably atomic.
> Because I don't want to send an IPI if the CPU already had bits set in
> the dependency.
>
> Ideally I need something like test_and_set_bit() but which returns the
> whole previous value and not just the previous value of the bit.

Ah, of course.  Peter, maybe we need atomic_or_return() as part
of your new atomic_or/_and/_xor series?  Certainly on tilegx, and
likely other architectures, we can do better than Frederic's
cmpxchg() loop.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/