MIME-Version: 1.0
In-Reply-To: <1437745668-31802-2-git-send-email-dvlasenk@redhat.com>
References: <1437745668-31802-1-git-send-email-dvlasenk@redhat.com> <1437745668-31802-2-git-send-email-dvlasenk@redhat.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Fri, 24 Jul 2015 10:50:28 -0700
Message-ID: <CALCETrXNN8aFHw1DX+qN20ovx8irVSd-LMpX1Jjr5J2ZT9vnzg@mail.gmail.com>
Subject: Re: [PATCH 2/3] x86/asm/entry/32: Remove most of SYSCALL32 code, part 1
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Krzysztof A. Sobiecki" <sobkas@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 23

On Fri, Jul 24, 2015 at 6:47 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> SYSCALL32 code is nearly identical to SYSCALL32, except for initial
> section. Merge them.
>
> The removal is split into two parts, to make review eaiser. This is part 1.
>
> auditsys_entry_common and auditsys_exit macros are indented one more tab without
> any changes. This prevents diff from becoming unreadable.
> They will be removed in part 2.

I need to read these more closely, which is, at present, exceeding my
ability to look at asm.  (See the big NMI thread.)  I'll look soon.

Meanwhile, this code is incredibly fragile wrt syscall restart.
(Syscall restart on compat is really weird.)  Do we have a decent test
for it?

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/