Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbbGXScO (ORCPT ); Fri, 24 Jul 2015 14:32:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:19495 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454AbbGXScN (ORCPT ); Fri, 24 Jul 2015 14:32:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,539,1432623600"; d="scan'208";a="529734741" Date: Fri, 24 Jul 2015 11:32:05 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, matt.fleming@intel.com, will.auld@intel.com, glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH V12 0/9] Hot cpu handling changes to cqm, rapl and Intel Cache Allocation support In-Reply-To: Message-ID: References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 43 Hello PeterZ, On Fri, 24 Jul 2015, Thomas Gleixner wrote: > On Wed, 1 Jul 2015, Vikas Shivappa wrote: >> Cache allocation patches(dependent on prep patches) adds a cgroup >> subsystem to support the new Cache Allocation feature found in future >> Intel Xeon Intel processors. Cache Allocation is a sub-feature with in >> Resource Director Technology(RDT) feature. RDT which provides support to >> control sharing of platform resources like L3 cache. > > Just a few general observations: > > 1) The changelogs need some loving care. > > 2) I let it up to PeterZ to decide whether he wants to fold the > sched support into switch_to. My prior answer to this was that - since cache alloc sched support doesnt deal with the register state (gen purpose, fpu , extended states ) did not want to bother the switch_to code. Also cache monitoring scheduling code falls in the finish_arch_switch. let me know if anything otherwise .. Thanks, Vikas > > Otherwise, I'm more or less content with the outcome of this patch > marathon. So for the whole pile: > > Reviewed-by: Thomas Gleixner > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/