Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964790AbbGXTBV (ORCPT ); Fri, 24 Jul 2015 15:01:21 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:35167 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314AbbGXTBR (ORCPT ); Fri, 24 Jul 2015 15:01:17 -0400 MIME-Version: 1.0 In-Reply-To: <1437465693-143982-1-git-send-email-long.wanglong@huawei.com> References: <1437465693-143982-1-git-send-email-long.wanglong@huawei.com> From: Rob Herring Date: Fri, 24 Jul 2015 14:00:57 -0500 Message-ID: Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn To: Wang Long Cc: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , peifeiyue@huawei.com, wanglong@laoqinren.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2516 Lines: 62 On Tue, Jul 21, 2015 at 3:01 AM, Wang Long wrote: > Update the last pr_warning callsite in drivers/of. That is obvious in the diff, but can you tell me why? Rob > Signed-off-by: Wang Long > --- > drivers/of/fdt.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 0749656..e1f61b8 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -425,7 +425,7 @@ static void __unflatten_device_tree(const void *blob, > start = 0; > unflatten_dt_node(blob, mem, &start, NULL, mynodes, 0, false); > if (be32_to_cpup(mem + size) != 0xdeadbeef) > - pr_warning("End of tree marker overwritten: %08x\n", > + pr_warn("End of tree marker overwritten: %08x\n", > be32_to_cpup(mem + size)); > > pr_debug(" <- unflatten_device_tree()\n"); > @@ -985,24 +985,24 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size) > size &= PAGE_MASK; > > if (base > MAX_PHYS_ADDR) { > - pr_warning("Ignoring memory block 0x%llx - 0x%llx\n", > + pr_warn("Ignoring memory block 0x%llx - 0x%llx\n", > base, base + size); > return; > } > > if (base + size - 1 > MAX_PHYS_ADDR) { > - pr_warning("Ignoring memory range 0x%llx - 0x%llx\n", > + pr_warn("Ignoring memory range 0x%llx - 0x%llx\n", > ((u64)MAX_PHYS_ADDR) + 1, base + size); > size = MAX_PHYS_ADDR - base + 1; > } > > if (base + size < phys_offset) { > - pr_warning("Ignoring memory block 0x%llx - 0x%llx\n", > + pr_warn("Ignoring memory block 0x%llx - 0x%llx\n", > base, base + size); > return; > } > if (base < phys_offset) { > - pr_warning("Ignoring memory range 0x%llx - 0x%llx\n", > + pr_warn("Ignoring memory range 0x%llx - 0x%llx\n", > base, phys_offset); > size -= phys_offset - base; > base = phys_offset; > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/