Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754292AbbGXTZv (ORCPT ); Fri, 24 Jul 2015 15:25:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58893 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333AbbGXTZt (ORCPT ); Fri, 24 Jul 2015 15:25:49 -0400 Subject: Re: [PATCH V7 4/5] arm64: apei: implement arch_apei_get_mem_attributes() To: Hanjun Guo , catalin.marinas@arm.com, will.deacon@arm.com, fu.wei@linaro.org, al.stone@linaro.org, "bp @ alien8 . de Matt Fleming" , rjw@rjwysocki.net References: <1437515960-16812-1-git-send-email-zjzhang@codeaurora.org> <1437515960-16812-5-git-send-email-zjzhang@codeaurora.org> <55B1AA08.3020706@linaro.org> Cc: linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org From: "Zhang, Jonathan Zhixiong" Message-ID: <55B2913A.2000504@codeaurora.org> Date: Fri, 24 Jul 2015 12:25:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55B1AA08.3020706@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 47 On 7/23/2015 7:59 PM, Hanjun Guo wrote: > On 07/22/2015 05:59 AM, Jonathan (Zhixiong) Zhang wrote: >> From: "Jonathan (Zhixiong) Zhang" >> >> If the physical address has memory attributes defined by EFI >> memmap as EFI_MEMORY_UC, the page protection type is >> PROT_DEVICE_nGnRE. Otherwise, the page protection type is >> PAGE_KERNEL. > > ... > > [...] >> +#ifdef CONFIG_ACPI_APEI >> +/* >> + * According to "Table 8 Map: EFI memory types to AArch64 memory types" >> + * of UEFI 2.5 section 2.3.6.1, each EFI memory type is mapped to >> + * corresponding MAIR attribute encoding. >> + */ >> +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) >> +{ >> + pgprot_t prot; >> + >> + prot = efi_mem_attributes(addr); >> + if (prot & EFI_MEMORY_UC) >> + return PROT_DEVICE_nGnRnE; >> + if (prot & EFI_MEMORY_WC) >> + return PROT_NORMAL_NC; >> + if (prot & EFI_MEMORY_WT) >> + return PROT_NORMAL_WT; >> + return PAGE_KERNEL; >> +} > > The change log is not matching the code here, and the PROT_DEVICE_nGnRE > in the change log is wrong, if you fix that, > > Acked-by: Hanjun Guo Thank you Hanjun for the catch and the ack. -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/