Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754453AbbGXT00 (ORCPT ); Fri, 24 Jul 2015 15:26:26 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:33099 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbGXT0Y (ORCPT ); Fri, 24 Jul 2015 15:26:24 -0400 Date: Fri, 24 Jul 2015 12:26:19 -0700 From: Dmitry Torokhov To: Rob Herring Cc: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] of/irq: introduce of_has_named_irqs helper Message-ID: <20150724192619.GA33241@dtor-ws> References: <20150724182655.GA22007@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1580 Lines: 45 On Fri, Jul 24, 2015 at 02:14:57PM -0500, Rob Herring wrote: > On Fri, Jul 24, 2015 at 1:26 PM, Dmitry Torokhov > wrote: > > Sometimes drivers might wish to transition from index-based to named > > interrupt descriptions. To aid in decision-making when parsing device > > tree data let's provide a helper that will indicate the scheme that is > > being used. > > Generally, IRQs are retrieved by platform_get_irq or > platform_get_irq_byname. Drivers should not call the of_irq_* > functions directly in most cases. That would be true for platform drivers, but not all devices are platform devices. > > > > > Signed-off-by: Dmitry Torokhov > > --- > > > > The intent is to it like this: > > > > if (of_has_named_irqs(np) { > > /* Wake IRQ is optional */ > > dev->wakeirq = of_irq_get_byname(np, "wakeup"); > > if (dev->wakeirq < 0 && dev->wakeirq != -ENODATA) > > return dev->wakeirq; > > } > > of_irq_get_byname will already return an error if the property is not > present. Use that. I do not like that it returns -EINVAL when property is missing, can we change it to return -ENODATA (so it is the same as when the property is defined but such name is missing)? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/