Message-ID: <55B29374.7040201@gmail.com>
Date: Fri, 24 Jul 2015 12:35:16 -0700
From: Florian Fainelli <f.fainelli@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Grant Likely <grant.likely@linaro.org>
CC: Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/irq: introduce of_has_named_irqs helper
References: <20150724182655.GA22007@dtor-ws>
In-Reply-To: <20150724182655.GA22007@dtor-ws>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1303
Lines: 39

On 24/07/15 11:26, Dmitry Torokhov wrote:
> Sometimes drivers might wish to transition from index-based to named
> interrupt descriptions. To aid in decision-making when parsing device
> tree data let's provide a helper that will indicate the scheme that is
> being used.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

[snip]

> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 3cf7a01..e02c43e 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -384,6 +384,19 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
>  EXPORT_SYMBOL_GPL(of_irq_to_resource);
>  
>  /**
> + * of_has_named_irq - Check if given node contains named interrupts
> + * @dev: pointer to device tree node
> + *
> + * Returns %true if node contains non-empty "interrupt-names" property.
> + */
> +bool of_has_named_irqs(struct device_node *dev)
> +{
> +	struct property *prop = of_find_property(dev, "interrupt-names", NULL);
> +
> +	return prop && prop->value;
> +}

Missing EXPORT_SYMBOL_GPL() here?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/