Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbbGXUcm (ORCPT ); Fri, 24 Jul 2015 16:32:42 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45545 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbGXUc1 (ORCPT ); Fri, 24 Jul 2015 16:32:27 -0400 Message-ID: <55B2A0C1.4000906@ti.com> Date: Fri, 24 Jul 2015 15:32:01 -0500 From: "Andrew F. Davis" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joe Perches , =?windows-1252?Q?Pali_Roh=E1r?= CC: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Dan Murphy , , Subject: Re: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking References: <1437601920-13045-1-git-send-email-afd@ti.com> <1437601920-13045-9-git-send-email-afd@ti.com> <20150723162212.GI29125@pali> <1437671193.26573.10.camel@perches.com> In-Reply-To: <1437671193.26573.10.camel@perches.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1985 Lines: 60 On 07/23/2015 12:06 PM, Joe Perches wrote: > On Thu, 2015-07-23 at 18:22 +0200, Pali Roh?r wrote: >> On Wednesday 22 July 2015 16:52:00 Andrew F. Davis wrote: >>> Reorganize the logic checking battery health and under temperature >>> condition checking. > [] >>> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c > [] >>> @@ -624,10 +626,34 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di) >>> */ >>> static int bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags) >>> { >>> - if (di->chip == BQ27500 || di->chip == BQ27541) >>> + if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545) >>> return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD); >>> + if (di->chip == BQ27530 || di->chip == BQ27421) >>> + return flags & BQ27XXX_FLAG_OT; >>> + >>> + return false; > > Maybe this int function should be bool or return 0 > instead of false. > >>> +static int bq27xxx_battery_undertemp(struct bq27xxx_device_info *di, u16 flags) >>> +{ >>> + if (di->chip == BQ27530 || di->chip == BQ27421) >>> + return flags & BQ27XXX_FLAG_UT; >>> + >>> + return false; >>> +} > > Here too > >>> + >>> +/* >>> + * Returns true if a low state of charge condition is detected >>> + */ >>> +static int bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags) >>> +{ >>> + if (di->chip == BQ27000 || di->chip == BQ27010) >>> + return flags & (BQ27000_FLAG_EDV1 | BQ27000_FLAG_EDVF); >>> else >>> - return flags & BQ27XXX_FLAG_OTC; >>> + return flags & (BQ27XXX_FLAG_SOC1 | BQ27XXX_FLAG_SOCF); >>> } > > and here > > I think I'll change the return to bool as these functions are only used in an if statement checking for true/false. Thanks, Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/