Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbbGXXVm (ORCPT ); Fri, 24 Jul 2015 19:21:42 -0400 Received: from smtp.citrix.com ([66.165.176.89]:33888 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754182AbbGXXVl (ORCPT ); Fri, 24 Jul 2015 19:21:41 -0400 X-IronPort-AV: E=Sophos;i="5.15,541,1432598400"; d="scan'208";a="284274572" Message-ID: <55B2C882.8050903@citrix.com> Date: Sat, 25 Jul 2015 00:21:38 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Vrabel , CC: Daniel Kiper , , , Boris Ostrovsky Subject: Re: [Xen-devel] [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages References: <1437738468-24110-1-git-send-email-david.vrabel@citrix.com> <1437738468-24110-11-git-send-email-david.vrabel@citrix.com> In-Reply-To: <1437738468-24110-11-git-send-email-david.vrabel@citrix.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 66 Hi David, On 24/07/2015 12:47, David Vrabel wrote: > Pages returned by alloc_xenballooned_pages() will be used for grant > mapping which will call set_phys_to_machine() (in PV guests). > > Ballooned pages are set as INVALID_P2M_ENTRY in the p2m and thus may > be using the (shared) missing tables and a subsequent > set_phys_to_machine() will need to allocate new tables. > > Since the grant mapping may be done from a context that cannot sleep, > the p2m entries must already be allocated. > > Signed-off-by: David Vrabel > --- > drivers/xen/balloon.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > index fd6970f3..8932d10 100644 > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -541,6 +541,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages) > { > int pgno = 0; > struct page *page; > + int ret = -ENOMEM; > > mutex_lock(&balloon_mutex); > > @@ -550,6 +551,11 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages) > page = balloon_retrieve(true); > if (page) { > pages[pgno++] = page; > +#ifdef CONFIG_XEN_HAVE_PVMMU > + ret = xen_alloc_p2m_entry(page_to_pfn(page)); Don't you want to call this function only when the guest is not using auto-translated physmap? > + if (ret < 0) > + goto out_undo; > +#endif > } else { > enum bp_state st; > > @@ -576,7 +582,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages) > out_undo: > mutex_unlock(&balloon_mutex); > free_xenballooned_pages(pgno, pages); > - return -ENOMEM; > + return ret; > } > EXPORT_SYMBOL(alloc_xenballooned_pages); > > Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/