Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbbGXX46 (ORCPT ); Fri, 24 Jul 2015 19:56:58 -0400 Received: from mout.gmx.net ([212.227.17.20]:61673 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbbGXX44 (ORCPT ); Fri, 24 Jul 2015 19:56:56 -0400 From: Peter Huewe To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Arnaud Patard , Peter Huewe Subject: [PATCH] staging/xgifb: fix dumpVGAReg compile error if DEBUG is set Date: Sat, 25 Jul 2015 01:59:08 +0200 Message-Id: <1437782348-32283-1-git-send-email-peterhuewe@gmx.de> X-Mailer: git-send-email 2.3.6 X-Provags-ID: V03:K0:SPqqIVMuuTdfufCaag6Ym6Qo253mL+nNLc5xDgtONyzMGpWDzSw BpRQW0rjHqzrKPTKKtjOxvuVBRHkH5YegbIVQ16TOehFPfLJ5hdMT9neLcMmVI2zl/QKDw8 KMC0XOngpMX8J8JOtFhcwkdLR8Zr3HH0NRMatn5jD/TVipPsVvy4nA5C3D+wn0SuSmfv/hY RmT0HZjbNDLLdrC4C3mwg== X-UI-Out-Filterresults: notjunk:1;V01:K0://Mp9mwcrjk=:3Bs/PeSabF2TvMEpchnp0y DGOf3QQVk8ofShg8OWdWfKW/KDGblix15Dftj4hV+MJwNMMZrI1Cu3IYTZNhrlaeA4PNmh9iZ FPHq5nwnCEv6pJLviWRnMrAAgfYuC9N6qyF8TdrmZ4g8zF5J3xV0dODT0hC8Wt+cFvTYCBGWL WxJ4fBK7ne/ZLA6A7PxRB41mkafcMWH0NZtoCCHQW09uWm4PHxE6Xrw978nb2jWslNQCr6RRD kzbC6v/RtCcJzt989qe2X/fAx0l0QDMns/zetPsN9/Fol0zPXGdll2XNweXJiADswR64urWgq X/Y1tRoyth5MWDoeXi07uevRMuaCyZxIZtSu8El6wxWCE949wyZrewyQMoTdgH5ESKhpsYARG 0BgNUBZGo6iP0KGqD9XaNrJ/thXZfRoyT2OO4wtiZuIgJ1iMyEQs4Zr2rCLEK0/xDYcWXNZ9U 76UVFTLZ/a/Fnyol21C3PxuZmmOD5qSaPLr/xY9v4Cl0aRUW4YLXXVYqQ9p2wtsfWlUy0XTKX 334k0WZO6GpezmKv8A6Wlk6u9im43WU8MqDyIS3U4XoQ5cWwQwWDxhjdCD8pzXTtsa2GjU3Wo 3pG4lHARPYyklB2qZSvkiISbL8/A5wCg+0txfTeL0lCbYVRZO0ouyIkZXW0kIyQ+RMNFjDZEj DN2brC8BIRLLkFQhG3qrVQGQJhRrtHPTyzJo+UjiXRZrXuw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1635 Lines: 59 If DEBUG is set dumpVGAReg is called and tries to access XGISR which is defined as (xgifb_info->dev_info.P3c4) which is not known within this function. -> add as parameter to dumpVGAReg so xgifb_info becomes known Signed-off-by: Peter Huewe --- drivers/staging/xgifb/XGI_main_26.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 943d463cf193..f3738400acd0 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++ b/drivers/staging/xgifb/XGI_main_26.c @@ -29,7 +29,7 @@ static unsigned int refresh_rate; /* -------------------- Macro definitions ---------------------------- */ #ifdef DEBUG -static void dumpVGAReg(void) +static void dumpVGAReg(struct xgifb_video_info *xgifb_info) { u8 i, reg; @@ -48,7 +48,7 @@ static void dumpVGAReg(void) } } #else -static inline void dumpVGAReg(void) +static inline void dumpVGAReg(struct xgifb_video_info *xgifb_info) { } #endif @@ -1073,7 +1073,7 @@ static int XGIfb_do_set_var(struct fb_var_screeninfo *var, int isactive, } XGIfb_bpp_to_var(xgifb_info, var); /*update ARGB info*/ - dumpVGAReg(); + dumpVGAReg(xgifb_info); return 0; } @@ -2019,7 +2019,7 @@ static int xgifb_probe(struct pci_dev *pdev, goto error_mtrr; } - dumpVGAReg(); + dumpVGAReg(xgifb_info); return 0; -- 2.3.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/