Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754246AbbGYA5V (ORCPT ); Fri, 24 Jul 2015 20:57:21 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:56345 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbbGYA5U (ORCPT ); Fri, 24 Jul 2015 20:57:20 -0400 Message-ID: <55B2DEE2.8080509@huawei.com> Date: Sat, 25 Jul 2015 08:57:06 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Rob Herring CC: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , , Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn References: <1437465693-143982-1-git-send-email-long.wanglong@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.152.157] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.55B2DEEA.012F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e7d148c3bee8c3ebf39774bdfc7ef60b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2952 Lines: 85 On 2015/7/25 3:00, Rob Herring wrote: > On Tue, Jul 21, 2015 at 3:01 AM, Wang Long wrote: >> Update the last pr_warning callsite in drivers/of. > > That is obvious in the diff, but can you tell me why? Hi Rob, When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning will produce WARNING: WARNING: Prefer pr_warn(... to pr_warning(... #22: FILE: drivers/of/fdt.c:428: + pr_warning("End of tree marker overwritten: %08x\n", So,we should convert pr_warning to pr_warn. Best Regards Wang Long > > Rob > >> Signed-off-by: Wang Long >> --- >> drivers/of/fdt.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c >> index 0749656..e1f61b8 100644 >> --- a/drivers/of/fdt.c >> +++ b/drivers/of/fdt.c >> @@ -425,7 +425,7 @@ static void __unflatten_device_tree(const void *blob, >> start = 0; >> unflatten_dt_node(blob, mem, &start, NULL, mynodes, 0, false); >> if (be32_to_cpup(mem + size) != 0xdeadbeef) >> - pr_warning("End of tree marker overwritten: %08x\n", >> + pr_warn("End of tree marker overwritten: %08x\n", >> be32_to_cpup(mem + size)); >> >> pr_debug(" <- unflatten_device_tree()\n"); >> @@ -985,24 +985,24 @@ void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size) >> size &= PAGE_MASK; >> >> if (base > MAX_PHYS_ADDR) { >> - pr_warning("Ignoring memory block 0x%llx - 0x%llx\n", >> + pr_warn("Ignoring memory block 0x%llx - 0x%llx\n", >> base, base + size); >> return; >> } >> >> if (base + size - 1 > MAX_PHYS_ADDR) { >> - pr_warning("Ignoring memory range 0x%llx - 0x%llx\n", >> + pr_warn("Ignoring memory range 0x%llx - 0x%llx\n", >> ((u64)MAX_PHYS_ADDR) + 1, base + size); >> size = MAX_PHYS_ADDR - base + 1; >> } >> >> if (base + size < phys_offset) { >> - pr_warning("Ignoring memory block 0x%llx - 0x%llx\n", >> + pr_warn("Ignoring memory block 0x%llx - 0x%llx\n", >> base, base + size); >> return; >> } >> if (base < phys_offset) { >> - pr_warning("Ignoring memory range 0x%llx - 0x%llx\n", >> + pr_warn("Ignoring memory range 0x%llx - 0x%llx\n", >> base, phys_offset); >> size -= phys_offset - base; >> base = phys_offset; >> -- >> 1.8.3.4 >> > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/