Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754814AbbGYCBk (ORCPT ); Fri, 24 Jul 2015 22:01:40 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:32857 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753145AbbGYCBh (ORCPT ); Fri, 24 Jul 2015 22:01:37 -0400 X-AuditID: cbfee690-f796f6d000005054-9c-55b2edff9d32 From: Kukjin Kim To: "'Olof Johansson'" , "'Javier Martinez Canillas'" Cc: "'Krzysztof Kozlowski'" , arm@kernel.org, "'Arnd Bergmann'" , "'Kevin Hilman'" , "'Doug Anderson'" , "'Kukjin Kim'" , linux-samsung-soc@vger.kernel.org, "'Linux Kernel'" References: <1431618016-2087-1-git-send-email-javier.martinez@collabora.co.uk> <1431618016-2087-3-git-send-email-javier.martinez@collabora.co.uk> <55A6FE07.7000604@samsung.com> <20150717164927.GA21691@localhost> In-reply-to: Subject: RE: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers Date: Sat, 25 Jul 2015 11:01:34 +0900 Message-id: <05ac01d0c67d$d581a740$8084f5c0$@kernel.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQGnzYAsc+pVz0k/C4c9X6pA4YGx5wMPgr3yAou7kLEBn2MuGgB0vDVDAUkHGYUCw8lk6Z3ffcNA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkRff/202hBrfXc1oc+7KFzeLvpGPs FmeXHWSzuPZ7BpvF6xeGFv2PXzNbfD28gtHi8q45bBYzzu9jsjh1/TObA5fH71+TGD1mN1xk 8fg7u5XZY9OqTjaPO9f2sHlcOdHE6tG3ZRWjx+dNcgEcUVw2Kak5mWWpRfp2CVwZuzYIFmwU r2h6s4GtgfGaUBcjJ4eEgInE5HtXmSFsMYkL99azdTFycQgJLGWUuHt3PRNM0cFJO5kgEosY Je7/v8gK4bxnlFh/9T1jFyMHB5uAskRjkz5Ig7CAlsTCLU0sILaIQKTE06t7WUDqmQXWMkk8 uP8HatIaZomvO96A7eYUCJbYOu8sI0R3isSBhVdYQWwWAVWJxS/esYHYvAIWEsvPnGOEsAUl fky+B7aBWUBdYtK8RcwQtrzE5jVvof5RkNhx9jUjxBUxEkfXr2OCqBGR2PfiHSPIERICSzkk +v8/ZoJYJiDxbfIhFpBvJARkJTYdgJojKXFwxQ2WCYySs5CsnoVk9Swkq2chWbGAkWUVo2hq QXJBcVJ6kYlecWJucWleul5yfu4mRmBKOP3v2YQdjPcOWB9iFOBgVOLhzZiwMVSINbGsuDL3 EKMp0EUTmaVEk/OBiSevJN7Q2MzIwtTE1NjI3NJMSZz3tdTPYCGB9MSS1OzU1ILUovii0pzU 4kOMTBycUg2MEmt2c09pfTc7TeySebSn9sb2RxeK7l9QPG+4ivf/x/CuGRN/q8rbyFyYfD7m 8qnI7wbLgzL9A78/Ygzc13t68f3IxBMZy+IKWdz+xeVM+NW4gkd2n8fnP8G/vcMKXTqzrQ6u 8Ku4nrflxbW1p4ymMEzKKot0ObPf1cVSULo6697Jc/98izoalFiKMxINtZiLihMBavujEAQD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNKsWRmVeSWpSXmKPExsVy+t9jAd3/bzeFGhzvYbE49mULm8XfScfY Lc4uO8hmce33DDaL1y8MLfofv2a2+Hp4BaPF5V1z2CxmnN/HZHHq+mc2By6P378mMXrMbrjI 4vF3diuzx6ZVnWwed67tYfO4cqKJ1aNvyypGj8+b5AI4ohoYbTJSE1NSixRS85LzUzLz0m2V vIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOAjlRSKEvMKQUKBSQWFyvp22GaEBripmsB 0xih6xsSBNdjZIAGEtYxZuzaIFiwUbyi6c0GtgbGa0JdjJwcEgImEgcn7WSCsMUkLtxbz9bF yMUhJLCIUeL+/4usEM57Ron1V98zdjFycLAJKEs0NumDNAgLaEks3NLEAmKLCERKPL26lwWk nllgLZPEg/t/mCCa1zBLfN3xhhmkilMgWGLrvLOMEN0pEgcWXmEFsVkEVCUWv3jHBmLzClhI LD9zjhHCFpT4Mfke2AZmAXWJSfMWMUPY8hKb17xlhjhbQWLH2deMEFfESBxdv44JokZEYt+L d4wTGIVnIRk1C8moWUhGzULSsoCRZRWjaGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcMJ5JrWD cWWDxSFGAQ5GJR7eA5M2hgqxJpYVV+YeYpTgYFYS4ZV8sClUiDclsbIqtSg/vqg0J7X4EKMp 0KcTmaVEk/OByTCvJN7Q2MTMyNLIzMLIxNxcSZz3ZL5PqJBAemJJanZqakFqEUwfEwenVAPj 1PTnLJ5zeh12dP3NkPrGoiJYf6ahbJ2DW8ILt6DHl+T/vfirOUWbMTHxiJ7oRdtTzrOsU9/I OeRFs4jy+tmKyueeOFS4SryKnz2uOOpmuU/ZBI13G+OXKp2Pbs/r2rjnCu/eTJNlG63+fNPI fiYgkRYW5n2ZRfYDR7SN7AvZidLJW9P3flRiKc5INNRiLipOBACtvTvDTgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3161 Lines: 82 Olof Johansson wrote: > > Hi, > Hi, > On Fri, Jul 17, 2015 at 11:47 AM, Javier Martinez Canillas > wrote: > > Hello Olof, > > > > On Fri, Jul 17, 2015 at 6:49 PM, Olof Johansson wrote: > >> On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote: > >>> On 16.07.2015 00:38, Javier Martinez Canillas wrote: > >>> > Hello, > >>> > > >>> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas > >>> > wrote: > >>> >> The Maxim max77802 Power Management IC is used on many Exynos machines. > >>> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC) > >>> >> and 2-channel 32kHz clock outputs. > >>> >> > >>> >> Enable the kernel config options to have the drivers for these devices > >>> >> built as a module. > >>> >> > >>> >> Signed-off-by: Javier Martinez Canillas > >>> >> --- > >>> >> arch/arm/configs/multi_v7_defconfig | 3 +++ > >>> >> 1 file changed, 3 insertions(+) > >>> >> > >>> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > >>> >> index 2349584b6e08..080120fe5580 100644 > >>> >> --- a/arch/arm/configs/multi_v7_defconfig > >>> >> +++ b/arch/arm/configs/multi_v7_defconfig > >>> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y > >>> >> CONFIG_REGULATOR_MAX8907=y > >>> >> CONFIG_REGULATOR_MAX8973=y > >>> >> CONFIG_REGULATOR_MAX77686=y > >>> >> +CONFIG_REGULATOR_MAX77802=m > >>> > > >>> > I noticed that the version that landed in 4.2-rc1 as commit > >>> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc > >>> > and clock drivers") doesn't include this symbol. I guess it was caused > >>> > by a wrong resolved conflict? I'll post a patch to enable the > >>> > regulator again. > >>> > >>> As you can see in mentioned mainline commit Kukjin removed it manually: > >>> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] > >>> > >>> I wonder why? > >> > >> Seems odd. exynos_defconfig still enables it. > >> It has been removed when I did 'make savedefconfig' at that time maybe because of dependency with other configs... > > Yeah since it is needed for at least the Exynos5420 Peach Pit and > > Exynos5800 Peach Pi Chromebooks that use this PMIC. > > > >> Javier or Krzysztof, please send an incremental fix to enable and I'll pick > >> it up as a fix. > >> > > > > I already posted an incremental patch [0] and Krzysztof is pushing it > > through Kukjin for 4.3 [1]. > > Yes. I'll send it out to arm-soc in this weekend. > > I guess that's OK and there is no need to add it as a fix for the 4.2 > > -rc cycle since this is not really a regression. I mean, the max77802 > > regulator driver was never enabled for multi_v7_defconfig before. > > Yeah, I came across those emails a little further down. :-) It's all > good, we'll see it come in later. > Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/