Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbbGYGZQ (ORCPT ); Sat, 25 Jul 2015 02:25:16 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45786 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754950AbbGYGZO (ORCPT ); Sat, 25 Jul 2015 02:25:14 -0400 Date: Fri, 24 Jul 2015 23:25:11 -0700 From: Christoph Hellwig To: Matias Bj?rling Cc: axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen.Bates@pmcs.com, keith.busch@intel.com Subject: Re: [PATCH v5 4/5] null_blk: LightNVM support Message-ID: <20150725062511.GA26437@infradead.org> References: <1437587464-7964-1-git-send-email-mb@lightnvm.io> <1437587464-7964-5-git-send-email-mb@lightnvm.io> <20150723095351.GB26420@infradead.org> <55B0C660.8010509@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B0C660.8010509@lightnvm.io> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 16 On Thu, Jul 23, 2015 at 12:48:00PM +0200, Matias Bj?rling wrote: > Only reason was to not duplicate the I/O submission/completion flow. > With the simple code at the moment, it is little to add. However, if > someone decides to put backing store, simulation, etc. into it, then it > should properly go into another module. > > Do you want me to move it into a new driver for this patchset? I'd prefer to have it separate unless there's a good reason to merge it into null_blk. From your above descriptions it sounds like it really should be separate. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/