Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932097AbbGYHvv (ORCPT ); Sat, 25 Jul 2015 03:51:51 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:10876 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbbGYHvu (ORCPT ); Sat, 25 Jul 2015 03:51:50 -0400 Date: Sat, 25 Jul 2015 09:50:52 +0200 From: Willy Tarreau To: Andy Lutomirski Cc: Andy Lutomirski , Peter Zijlstra , Steven Rostedt , "security@kernel.org" , X86 ML , Borislav Petkov , Sasha Levin , "linux-kernel@vger.kernel.org" , Konrad Rzeszutek Wilk , Boris Ostrovsky , Andrew Cooper , Jan Beulich , xen-devel Subject: Re: [PATCH v4 2/3] x86/ldt: Make modify_ldt optional Message-ID: <20150725075052.GA3918@1wt.eu> References: <7286d77aa81abc38dc40362e2439861427064f6f.1437802102.git.luto@kernel.org> <20150725062343.GA3902@1wt.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 39 On Fri, Jul 24, 2015 at 11:44:52PM -0700, Andy Lutomirski wrote: > I'm all for it, but I think it should be hard-disablable in config, > too, for the -tiny people. I totally agree. > If we add a runtime disable, let's do a > separate patch, and you and Kees can fight over how general it should > be. Initially I was thinking about changing it for a 3-state option but that would prevent X86_16BIT from being hard-disablable, so I'll do something completely separate. > > That's why here I think we should do the same, and possibly even > > emit a warning once to report the first user of modify_ldt if that > > can help. > > > > What do you think ? > > I'm generally in favor. OK. > On the other hand, the current series is already written, might even > be compatible with Xen, and patch 1 at least fixes a real bug. Maybe > several real bugs. That's my guess as well given how hard it seems for everyone in this long thread to imagine all possible bugs we can face :-/ Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/