Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbbGYIZN (ORCPT ); Sat, 25 Jul 2015 04:25:13 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33278 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754726AbbGYIZK (ORCPT ); Sat, 25 Jul 2015 04:25:10 -0400 Message-ID: <55B347DC.2090104@linaro.org> Date: Sat, 25 Jul 2015 16:25:00 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Marc Zyngier , Bjorn Helgaas , Thomas Gleixner , Jiang Liu , Jason Cooper CC: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Subject: Re: [PATCH v5 07/19] PCI/MSI: Let pci_msi_get_domain use struct device's msi_domain References: <1437643598-19795-1-git-send-email-marc.zyngier@arm.com> <1437643598-19795-8-git-send-email-marc.zyngier@arm.com> In-Reply-To: <1437643598-19795-8-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 48 On 07/23/2015 05:26 PM, Marc Zyngier wrote: > Now that we can easily find which MSI domain a PCI device is > using, use dev_get_msi_domain as a way to retrieve the information. > > The original code is still used as a fallback. > > Signed-off-by: Marc Zyngier > --- > drivers/pci/msi.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c > index ef4ec6e..da3c607 100644 > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -39,14 +39,16 @@ struct irq_domain * __weak arch_get_pci_msi_domain(struct pci_dev *dev) > > static struct irq_domain *pci_msi_get_domain(struct pci_dev *dev) > { > - struct irq_domain *domain = NULL; > + struct irq_domain *domain; > + > + domain = dev_get_msi_domain(&dev->dev); > + if (domain) > + return domain; > > - if (dev->bus->msi) > - domain = dev->bus->msi->domain; > - if (!domain) > - domain = arch_get_pci_msi_domain(dev); > + if (dev->bus->msi && (domain = dev->bus->msi->domain)) > + return domain; > > - return domain; > + return arch_get_pci_msi_domain(dev); > } > > static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) Reviewed-by: Hanjun Guo Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/