Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754675AbbGYJ2T (ORCPT ); Sat, 25 Jul 2015 05:28:19 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:33400 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbbGYJ2R (ORCPT ); Sat, 25 Jul 2015 05:28:17 -0400 Message-ID: <1437816495.25825.59.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: Spencer Baugh , Sagi Grimberg , Bart Van Assche , Alexei Potashnik , Andy Grover , Christophe Vu-Brugier , Roland Dreier , "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" , open list , Joern Engel , Spencer Baugh Date: Sat, 25 Jul 2015 02:28:15 -0700 In-Reply-To: <20150725064849.GA8052@lst.de> References: <1437689973-22991-1-git-send-email-sbaugh@catern.com> <20150724105206.GA25162@lst.de> <1437769934.26220.8.camel@haakon3.risingtidesystems.com> <20150725064849.GA8052@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 22 On Sat, 2015-07-25 at 08:48 +0200, Christoph Hellwig wrote: > On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote: > > We've already been through this discussion a couple of years back when > > target_submit_cmd() first came into existence. > > > > The reason iscsi/iser-target continues to be a special case is due to > > immediate data vs. non immediate data and their respective command > > sequence number ordering requirements. > > I don't see how immediate data plays into this, the write_pending > callbacks can simply skip the data transfer path, similar to what > Bart's port of the latest SRP target to lio does as well. iscsit_execute_cmd() is using iscsit_transport->iscsit_get_dataout() for any remaining solicited data-out (R2T/RDMA_READ) payload when immediate write data is smaller than total EDTL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/