Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754939AbbGYNeK (ORCPT ); Sat, 25 Jul 2015 09:34:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49954 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754370AbbGYNeI (ORCPT ); Sat, 25 Jul 2015 09:34:08 -0400 Message-ID: <55B3904B.3050408@free-electrons.com> Date: Sat, 25 Jul 2015 15:34:03 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Rob Herring CC: linux-arm-kernel@lists.infradead.org, Russell King , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, arm@kernel.org, Alexander Shiyan , Stephen Warren , Lee Jones , linux-kernel@vger.kernel.org, Kukjin Kim , linux-rpi-kernel@lists.infradead.org, Thomas Gleixner , Maxime Ripard , Jason Cooper Subject: Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage References: <1436711211-18223-1-git-send-email-robh@kernel.org> <1436711211-18223-7-git-send-email-robh@kernel.org> In-Reply-To: <1436711211-18223-7-git-send-email-robh@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2575 Lines: 76 Hi Rob, On 12/07/2015 16:26, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Stephen Warren > Cc: Lee Jones > Cc: Alexander Shiyan > Cc: Maxime Ripard > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > --- > v2: > - Fix build error on clps711x > [...] > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c > index 0d3b0fe..b8bf8b0 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -201,7 +201,6 @@ static int armada_370_xp_msi_map(struct irq_domain *domain, unsigned int virq, > { > irq_set_chip_and_handler(virq, &armada_370_xp_msi_irq_chip, > handle_simple_irq); > - set_irq_flags(virq, IRQF_VALID); OK > > return 0; > } > @@ -318,7 +317,7 @@ static int armada_370_xp_mpic_irq_map(struct irq_domain *h, > irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip, > handle_level_irq); > } > - set_irq_flags(virq, IRQF_VALID | IRQF_PROBE); > + irq_set_noprobe(virq); I think it should be irq_set_probe(virq), I don't see why you inverted the probe flag. Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/