Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbbGZLsX (ORCPT ); Sun, 26 Jul 2015 07:48:23 -0400 Received: from www.linutronix.de ([62.245.132.108]:53205 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753143AbbGZLsW (ORCPT ); Sun, 26 Jul 2015 07:48:22 -0400 Date: Sun, 26 Jul 2015 13:48:03 +0200 (CEST) From: Thomas Gleixner To: Shenwei Wang cc: shawn.guo@linaro.org, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, b20788@freescale.com Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources In-Reply-To: <1437584859-64203-2-git-send-email-shenwei.wang@freescale.com> Message-ID: References: <1437584859-64203-1-git-send-email-shenwei.wang@freescale.com> <1437584859-64203-2-git-send-email-shenwei.wang@freescale.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 23 On Wed, 22 Jul 2015, Shenwei Wang wrote: > +static int imx_gpcv2_irq_set_wake(struct irq_data *d, unsigned int on) > +{ > + struct imx_gpcv2_irq *cd = d->chip_data; > + unsigned int idx = d->hwirq / 32; > + unsigned long flags; > + void __iomem *reg; > + u32 mask, val; > + > + raw_spin_lock_irqsave(&cd->lock.rlock, flags); Oh no. You need to make cd->lock a raw_spinlock and then use raw_spin_lock_irqsave() on it. How on earth did you come up with this hackery? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/