Date: Sun, 26 Jul 2015 16:42:44 +0200
From: Borislav Petkov <bp@alien8.de>
To: Philip =?utf-8?Q?M=C3=BCller?= <philm@manjaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        Guenter Roeck <linux@roeck-us.net>, manjaro-dev@manjaro.org,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andre Przywara <andre.przywara@arm.com>, Borislav Petkov <bp@suse.de>
Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs
 code to generic infrastructure' on AMD i686
Message-ID: <20150726144244.GA15550@nazgul.tnic>
References: <55B16967.1040609@manjaro.org>
 <55B47BB8.6080202@manjaro.org>
 <alpine.DEB.2.11.1507261012480.18576@nanos>
 <20150726084154.GA14829@nazgul.tnic>
 <55B4BC7F.1060402@manjaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55B4BC7F.1060402@manjaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 33

On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
> I can confirm your patch working. However, it might be good to use yours
> and Thomas' in combination to solve this properly.

Please do not top-post.

We could use Thomas' too although from looking at it,
detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
for each CPU. By the time we hit cache_shared_cpu_map_remove() in
free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
allocated. We kfree them in the next step only.

But I like the moving of the check from the CPU hotplug callback to
free_cache_attributes().

So I'll merge the two patches and write up a proper commit message,
unless someone objects.

I'll add your Tested-by too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/