Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249AbbGZP7Y (ORCPT ); Sun, 26 Jul 2015 11:59:24 -0400 Received: from static.148.38.9.176.clients.your-server.de ([176.9.38.148]:48678 "EHLO manjaro.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755181AbbGZP7X (ORCPT ); Sun, 26 Jul 2015 11:59:23 -0400 Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686 To: Borislav Petkov References: <55B16967.1040609@manjaro.org> <55B47BB8.6080202@manjaro.org> <20150726084154.GA14829@nazgul.tnic> <55B4BC7F.1060402@manjaro.org> <20150726144244.GA15550@nazgul.tnic> Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Sudeep Holla , Guenter Roeck , manjaro-dev@manjaro.org, Ingo Molnar , "H. Peter Anvin" , Andre Przywara , Borislav Petkov From: =?UTF-8?Q?Philip_M=c3=bcller?= Message-ID: <55B503D7.6070405@manjaro.org> Date: Sun, 26 Jul 2015 17:59:19 +0200 MIME-Version: 1.0 In-Reply-To: <20150726144244.GA15550@nazgul.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 42 Hi Borislav, I'm fine with that decision. I tested your patch alone and the combination with Thomas' changes. Both work to solve this problem. Do whatever suits best for this matter. Thx to you too for providing solutions so fast. kind regards Philip p.s. what do you mean by top-post? Am 26.07.2015 um 16:42 schrieb Borislav Petkov: > On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote: >> I can confirm your patch working. However, it might be good to use yours >> and Thomas' in combination to solve this properly. > > Please do not top-post. > > We could use Thomas' too although from looking at it, > detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing > for each CPU. By the time we hit cache_shared_cpu_map_remove() in > free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still > allocated. We kfree them in the next step only. > > But I like the moving of the check from the CPU hotplug callback to > free_cache_attributes(). > > So I'll merge the two patches and write up a proper commit message, > unless someone objects. > > I'll add your Tested-by too. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/