Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755328AbbGZQLN (ORCPT ); Sun, 26 Jul 2015 12:11:13 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:52795 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbbGZQLM (ORCPT ); Sun, 26 Jul 2015 12:11:12 -0400 Message-ID: <55B5069A.8070209@roeck-us.net> Date: Sun, 26 Jul 2015 09:11:06 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: =?UTF-8?B?UGhpbGlwIE3DvGxsZXI=?= , Borislav Petkov CC: Thomas Gleixner , linux-kernel@vger.kernel.org, Sudeep Holla , manjaro-dev@manjaro.org, Ingo Molnar , "H. Peter Anvin" , Andre Przywara , Borislav Petkov Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686 References: <55B16967.1040609@manjaro.org> <55B47BB8.6080202@manjaro.org> <20150726084154.GA14829@nazgul.tnic> <55B4BC7F.1060402@manjaro.org> <20150726144244.GA15550@nazgul.tnic> <55B503D7.6070405@manjaro.org> In-Reply-To: <55B503D7.6070405@manjaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 52 On 07/26/2015 08:59 AM, Philip Müller wrote: > Hi Borislav, > > I'm fine with that decision. I tested your patch alone and the > combination with Thomas' changes. Both work to solve this problem. > > Do whatever suits best for this matter. Thx to you too for providing > solutions so fast. > > kind regards > Philip > > p.s. what do you mean by top-post? > What you just did ;-). http://ck.wikia.com/wiki/TopPosting Guenter > Am 26.07.2015 um 16:42 schrieb Borislav Petkov: >> On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote: >>> I can confirm your patch working. However, it might be good to use yours >>> and Thomas' in combination to solve this properly. >> >> Please do not top-post. >> >> We could use Thomas' too although from looking at it, >> detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing >> for each CPU. By the time we hit cache_shared_cpu_map_remove() in >> free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still >> allocated. We kfree them in the next step only. >> >> But I like the moving of the check from the CPU hotplug callback to >> free_cache_attributes(). >> >> So I'll merge the two patches and write up a proper commit message, >> unless someone objects. >> >> I'll add your Tested-by too. >> >> Thanks. >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/