Date: Sun, 26 Jul 2015 18:31:53 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: a.p.zijlstra@chello.nl, acme@kernel.org, luto@kernel.org, mingo@redhat.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        adrian.hunter@intel.com, jolsa@kernel.org, namhyung@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct
 perf_sample
Message-ID: <20150726163153.GF24646@krava.brq.redhat.com>
References: <1437745712-16649-1-git-send-email-kan.liang@intel.com>
 <1437745712-16649-5-git-send-email-kan.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1437745712-16649-5-git-send-email-kan.liang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 34

On Fri, Jul 24, 2015 at 09:48:30AM -0400, kan.liang@intel.com wrote:

SNIP

> +	u64 nr = 0;
>  
>  	if (sid) {
>  		sample->id     = v->id;
> @@ -1010,6 +1012,20 @@ static int deliver_sample_value(struct perf_evlist *evlist,
>  		return 0;
>  	}
>  
> +	if (perf_evsel__is_group_leader(sid->evsel)) {
> +		evsel = sid->evsel;
> +		SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> +				    sample->read.group.values[nr].value);
> +		evlist__for_each_continue(evlist, evsel) {
> +			if ((evsel->leader != sid->evsel) ||
> +			    (++nr >= sample->read.group.nr))
> +				break;
> +
> +			SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data,
> +					    sample->read.group.values[nr].value);

I think this should be in upper layer.. why not do this also
within iter_prepare_normal_entry as for the rest of the calculations
I suggested in my other email

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/