Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755319AbbG0Ce3 (ORCPT ); Sun, 26 Jul 2015 22:34:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:36870 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbbG0Ce2 (ORCPT ); Sun, 26 Jul 2015 22:34:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,550,1432623600"; d="scan'208";a="770190110" Date: Mon, 27 Jul 2015 02:43:25 +0800 From: Yuyang Du To: Boqun Feng Cc: mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, pjt@google.com, bsegall@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, umgwanakikbuti@gmail.com, len.brown@intel.com, rafael.j.wysocki@intel.com, arjan@linux.intel.com, fengguang.wu@intel.com Subject: Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Message-ID: <20150726184325.GB28512@intel.com> References: <1436918682-4971-1-git-send-email-yuyang.du@intel.com> <1436918682-4971-7-git-send-email-yuyang.du@intel.com> <20150721010346.GA2882@fixme-laptop.cn.ibm.com> <20150721004400.GA28512@intel.com> <20150721101845.GB2882@fixme-laptop.cn.ibm.com> <20150721102956.GA5380@fixme-laptop.cn.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150721102956.GA5380@fixme-laptop.cn.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 22 Hi Boqun, On Tue, Jul 21, 2015 at 06:29:56PM +0800, Boqun Feng wrote: > The point is that you have already tracked the sum of runnable_load_avg > and blocked_load_avg in cfs_rq->avg.load_avg. If you're going to track > part of the sum, you'd better track the one that's updated less > frequently, right? > > Anyway, this idea just comes into my mind. I wonder which is udpated > less frequently myself too. ;-) So I ask to see whether there is > something we can improve. Actually, this is not the point. 1) blocked load is more "difficult" to track, hint, migrate. 2) r(t1) - b(t2) is not anything, hint, t1 != t2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/