Message-ID: <1437939564.2669.96.camel@perches.com>
Subject: Re: [PATCH] Staging:dgap :Compression of lines for immediate return
From: Joe Perches <joe@perches.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: linux-kernel@vger.kernel.org
Date: Sun, 26 Jul 2015 12:39:24 -0700
In-Reply-To: <20150726173413.GA30485@shraddha-370R4E-370R4V-370R5E-3570RE-370R5V>
References: <20150726173413.GA30485@shraddha-370R4E-370R4V-370R5E-3570RE-370R5V>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 822
Lines: 31

On Sun, 2015-07-26 at 23:04 +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as follows:
> 
> @@
> expression ret;
> identifier f;
> @@
> -ret =
> +return
>      f(...);
> -return ret;

This isn't an always safe or side-effect free
semantic patch as there may be a cast lost by
such a conversion.

int foo(void)
{
	char i = 0xffffffff;
	return i;
}

where i is now int not char

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/