Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbbGZUj6 (ORCPT ); Sun, 26 Jul 2015 16:39:58 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:34747 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754550AbbGZUj5 (ORCPT ); Sun, 26 Jul 2015 16:39:57 -0400 MIME-Version: 1.0 In-Reply-To: <55B2DEE2.8080509@huawei.com> References: <1437465693-143982-1-git-send-email-long.wanglong@huawei.com> <55B2DEE2.8080509@huawei.com> From: Rob Herring Date: Sun, 26 Jul 2015 15:39:36 -0500 Message-ID: Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn To: "long.wanglong" Cc: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , peifeiyue@huawei.com, wanglong@laoqinren.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 26 On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong wrote: > On 2015/7/25 3:00, Rob Herring wrote: >> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long wrote: >>> Update the last pr_warning callsite in drivers/of. >> >> That is obvious in the diff, but can you tell me why? > > Hi Rob, > > When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning > will produce WARNING: > > WARNING: Prefer pr_warn(... to pr_warning(... > #22: FILE: drivers/of/fdt.c:428: > + pr_warning("End of tree marker overwritten: %08x\n", > > So,we should convert pr_warning to pr_warn. Okay, but don't explain to me. Explain this in the commit message. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/