Date: Sun, 26 Jul 2015 23:51:45 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>, linux-arm-kernel@lists.infradead.org,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to
 Kconfig
Message-ID: <20150726225145.GF7576@n2100.arm.linux.org.uk>
References: <1437612483-30160-1-git-send-email-sre@kernel.org>
 <1437612483-30160-4-git-send-email-sre@kernel.org>
 <20150723123553.GE7576@n2100.arm.linux.org.uk>
 <20150724001605.GA1453@earth>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150724001605.GA1453@earth>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1749
Lines: 42

On Fri, Jul 24, 2015 at 02:16:06AM +0200, Sebastian Reichel wrote:
> Hi Russel,
> 
> On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote:
> > > Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results
> > > in one option less to think about when configuring the kernel.
> > 
> > > -#if defined(CONFIG_ARM_ERRATA_430973) && !defined(CONFIG_ARCH_MULTIPLATFORM)
> > > +#ifdef CONFIG_ARM_ERRATA_430973
> > >  	teq	r3, #0x00100000			@ only present in r1p*
> > >  	mrceq	p15, 0, r0, c1, c0, 1		@ read aux control register
> > >  	orreq	r0, r0, #(1 << 6)		@ set IBE to 1
> > 
> > NAK.  Please read the mailing list history, I'm not repeating myself
> > again on this.  Thanks.
> 
> It's a bit hard to search the mailing list history without a bit
> more information.

You were Cc'd on the previous round of review...

> I guess you prefer to just add the !ARCH_MULTIPLATFORM dependency to
> the Kconfig entry without removing the additional check in the code?

I was referring to the above change.

However, having discussed with Will Deacon and checked the manuals, I
think the change is okay after all: the auxillary control register is
banked on secure parts, and the bit we'll be trying to change will be
read-only in non-secure mode - and importantly won't fault.

So, the change is fine, thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/