Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbbG0GGi (ORCPT ); Mon, 27 Jul 2015 02:06:38 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:52569 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbbG0GGh (ORCPT ); Mon, 27 Jul 2015 02:06:37 -0400 X-AuditID: 85900ec0-9f5ccb9000001a57-5a-55b5ca33dd53 X-Mailbox-Line: From nobody Mon Jul 27 14:55:16 2015 Subject: [PATCH 0/7] ipmi: various fixes for panic notifier robustness To: Corey Minyard From: Hidehiro Kawai Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2015 14:55:16 +0900 Message-ID: <20150727055516.4759.34462.stgit@softrs> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 45 This patche set fixes multiple bugs in IPMI driver especially for the panic notifier callback panic_event() and related functions. This callback is called before kdump if crash_kexec_post_notifiers boot option is specified, so its robustness is very important. panic_event() first tries to flush queued messages before panic, and this can cause multiple trouble such as hang-up. PATCH 3 to 6 addresses this kind of problems. PATCH 7 addresses a problem caused by malfunctioning BMC. NOTE: I'm planning to post another patch set which includes a patch to drop all queued messages at the beginning of panic_event() if crash_kexec_post_notifiers boot option is specified. This will improve the robustness of the panic notifier callback. --- Hidehiro Kawai (7): ipmi: Remove unneeded set_run_to_completion call ipmi: Factor out message flushing procedure ipmi: Don't flush messages in sneder() in run-to-completion mode ipmi: Avoid touching possible corrupted lists in the panic context ipmi: Don't call receive handler in the panic context ipmi: Handle queued messages more certainly on panic ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE drivers/char/ipmi/ipmi_kcs_sm.c | 4 ++ drivers/char/ipmi/ipmi_msghandler.c | 66 +++++++++++++++++++++++++++++++++-- drivers/char/ipmi/ipmi_si_intf.c | 45 ++++++++++++------------ include/linux/ipmi_smi.h | 10 +++++ 4 files changed, 100 insertions(+), 25 deletions(-) -- Hidehiro Kawai Hitachi, Ltd. Research & Development Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/