Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbbG0HJz (ORCPT ); Mon, 27 Jul 2015 03:09:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:40382 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750899AbbG0HJy (ORCPT ); Mon, 27 Jul 2015 03:09:54 -0400 Date: Mon, 27 Jul 2015 09:09:50 +0200 From: Thomas Petazzoni To: Maxime Ripard Cc: Vinod Koul , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Boris Brezillon , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dmaengine: Add an enum for the dmaengine alignment constraints Message-ID: <20150727090950.37122de2@free-electrons.com> In-Reply-To: <20150727064804.GN2564@lukather> References: <1437381693-18948-1-git-send-email-maxime.ripard@free-electrons.com> <20150720110325.502af335@free-electrons.com> <20150727064804.GN2564@lukather> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 24 Maxime, On Mon, 27 Jul 2015 08:48:04 +0200, Maxime Ripard wrote: > I could, but all the rest of the other similar case so far in > dmaengine are made through enum, so I guess it's still better for > consistency. And we also provide a comprehensive list of the valid > values this way, something a function would not provide (or at least > not at compilation time) Alright, makes sense. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/