Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbG0H3a (ORCPT ); Mon, 27 Jul 2015 03:29:30 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38575 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbbG0H32 (ORCPT ); Mon, 27 Jul 2015 03:29:28 -0400 Date: Mon, 27 Jul 2015 08:29:18 +0100 From: Lee Jones To: Mark Brown Cc: Bjorn Andersson , "bjorn@kryo.se" , Andy Gross , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [PATCH v2 05/11] mfd: devicetree: bindings: Add Qualcomm SMD based RPM DT binding Message-ID: <20150727072918.GU3436@x1> References: <1435355419-23602-1-git-send-email-bjorn.andersson@sonymobile.com> <1435355419-23602-6-git-send-email-bjorn.andersson@sonymobile.com> <20150707121609.GZ3182@x1> <20150713214836.GA15178@usrtlx11787.corpusers.net> <20150723133133.GB3436@x1> <20150723164128.GD4753@usrtlx11787.corpusers.net> <20150723171638.GE11162@sirena.org.uk> <20150724095847.GC3436@x1> <20150724102434.GF11162@sirena.org.uk> <20150724172316.GR11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150724172316.GR11162@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2592 Lines: 67 On Fri, 24 Jul 2015, Mark Brown wrote: > On Fri, Jul 24, 2015 at 11:24:34AM +0100, Mark Brown wrote: > > On Fri, Jul 24, 2015 at 10:58:47AM +0100, Lee Jones wrote: > > > On Thu, 23 Jul 2015, Mark Brown wrote: > > > > > I have no idea what's going on here, sorry. I've not been reading this > > > > thread. > > > > All of the information you need is in the email you replied to. > > > The mail appears to have an edited down section of what looks like an > > example rather than the actual binding. I haven't seen the binding so I > > can't really comment on it. > > I managed to find the binding but I'm afraid I'm still not sure what the > concern here is - can someone please be specific about the question(s) > you're looking for an answer on? [...] >From here: > > > > > + pm8941-regulators { > > > > > + compatible = "qcom,rpm-pm8941-regulators"; > > > > > + vdd_l13_l20_l23_l24-supply = <&pm8941_boost>; > > > > > > > > I'd like Mark to glance at this. Mark: Is this new property okay? > > > > > + pm8941_s3: s3 { > > > > > + regulator-min-microvolt = <1800000>; > > > > > + regulator-max-microvolt = <1800000>; > > > > > > > > Aren't these fixed regulators? > > > > > > In this system configuration most of the regulators have fixed values, > > > but the regulators (hw) are not fixed. > > > > I'm not sure that's how it works. I believe 'max' and 'min' should > > describe the upper and lower constraints of the regulator. The actual > > value it runs it is selected elsewhere. > > The specified range of the regulator is 1.75-1.85V and this is handled > by the implementation, however the board designers have stated that it > is only allowed to be configured to 1.8V. > > So DT is used to narrow the capabilities of the individual component to > something that's suitable for this particular system. > > > We still need Mark to look at this. Is it okay for the regulator-{min,max}-microvolt to be artificially restricted to the required value, despite knowing that the regulator is capable of supply {more,less} voltage? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/