Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752759AbbG0I4X (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jul 2015 04:56:23 -0400
Received: from foss.arm.com ([217.140.101.70]:51453 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751416AbbG0I4V (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jul 2015 04:56:21 -0400
Message-ID: <55B5F231.5090105@arm.com>
Date: Mon, 27 Jul 2015 09:56:17 +0100
From: Sudeep Holla <sudeep.holla@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Borislav Petkov <bp@suse.de>, Thomas Gleixner <tglx@linutronix.de>
CC: Sudeep Holla <sudeep.holla@arm.com>,
        =?UTF-8?B?UGhpbGlwIE3DvGxsZXI=?= <philm@manjaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "manjaro-dev@manjaro.org" <manjaro-dev@manjaro.org>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH] cpu/cacheinfo: Fix teardown path
References: <55B16967.1040609@manjaro.org> <55B47BB8.6080202@manjaro.org> <20150727075805.GA20416@nazgul.tnic>
In-Reply-To: <20150727075805.GA20416@nazgul.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1897
Lines: 50



On 27/07/15 08:58, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 27 Jul 2015 08:36:27 +0200
> Subject: [PATCH] cpu/cacheinfo: Fix teardown path
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Philip Müller reported a hang when booting 32-bit 4.1 kernel on an AMD
> box. A fragment of the splat was enough to pinpoint the issue:
>
>    task: f58e0000 ti: f58e8000 task.ti: f58e800
>    EIP: 0060:[<c135a903>] EFLAGS: 00010206 CPU: 0
>    EIP is at free_cache_attributes+0x83/0xd0
>    EAX: 00000001 EBX: f589d46c ECX: 00000090 EDX: 360c2000
>    ESI: 00000000 EDI: c1724a80 EBP: f58e9ec0 ESP: f58e9ea0
>     DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
>    CR0: 8005003b CR2: 000000ac CR3: 01731000 CR4: 000006d0
>
> cache_shared_cpu_map_setup() did check sibling CPUs cacheinfo descriptor
> while the respective teardown path cache_shared_cpu_map_remove() didn't.
> Fix that.
>
>  From tglx's version: to be on the safe side, move the cacheinfo
> descriptor check to free_cache_attributes(), thus cleaning up the
> hotplug path a little and making this even more robust.
>
> Reported-by: Philip Müller <philm@manjaro.org>
> Cc: <stable@vger.kernel.org> # 4.1
> Cc: Andre Przywara <andre.przywara@arm.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: manjaro-dev@manjaro.org
> Cc: Philip Müller <philm@manjaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>

Looks good to me. If not too late
Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/