Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754464AbbG0J3Z (ORCPT ); Mon, 27 Jul 2015 05:29:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:33650 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbG0J3V (ORCPT ); Mon, 27 Jul 2015 05:29:21 -0400 Message-ID: <1437989357.32457.3.camel@suse.com> Subject: Re: [PATCH 3/4] cp210x: Store part number From: Oliver Neukum To: Petr Tesarik Cc: Johan Hovold , Greg Kroah-Hartman , PetrTesarik , open list , "open list:USB SERIAL SUBSYSTEM" Date: Mon, 27 Jul 2015 11:29:17 +0200 In-Reply-To: <20150727085039.1627db72@hananiah.suse.cz> References: <1437720491-28702-1-git-send-email-ptesarik@suse.com> <1437720491-28702-4-git-send-email-ptesarik@suse.com> <1437917574.5839.2.camel@suse.com> <20150727085039.1627db72@hananiah.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 27 On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote: > I don't understand. While you're right that I copied this part from > Sillicon Labs' driver without much thinking, and &spriv->bPartNumber > can be used directly, I can't see any DMA on stack. FWIW > cp210x_control_msg always allocates a buffer using kcalloc: > > buf = kcalloc(length, sizeof(__le32), GFP_KERNEL); > /* ... */ > result = usb_control_msg(serial->dev, > usb_rcvctrlpipe(serial->dev, 0), > request, requesttype, value, > spriv->bInterfaceNumber, buf, size, > timeout); > > Is that what you mean? Yes, sorry, that part wasn't so clear from the previous patch. Sorry Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/