Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbbG0LC3 (ORCPT ); Mon, 27 Jul 2015 07:02:29 -0400 Received: from foss.arm.com ([217.140.101.70]:52385 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbbG0LC0 (ORCPT ); Mon, 27 Jul 2015 07:02:26 -0400 Message-ID: <55B60FBE.7060606@arm.com> Date: Mon, 27 Jul 2015 12:02:22 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Petazzoni , Gregory CLEMENT CC: Sudeep Holla , Lior Amsalem , Andrew Lunn , Jason Cooper , Tawfik Bayouk , Boris BREZILLON , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Nadav Haklai , Ezequiel Garcia , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth Subject: Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode References: <1435684740-24912-1-git-send-email-gregory.clement@free-electrons.com> <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> <20150701175436.7dff0754@free-electrons.com> In-Reply-To: <20150701175436.7dff0754@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 37 Hi Thomas/Gregory, On 01/07/15 16:54, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote: > >> static void __init mvebu_init_irq(void) >> { >> + if (of_machine_is_compatible("marvell,armada375") || >> + of_machine_is_compatible("marvell,armada380") || >> + of_machine_is_compatible("marvell,armada390")) > > What we really want to know is if we're using the GIC, so what about > instead: > > np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic"); > if (np) > gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE | > IRQCHIP_MASK_ON_SUSPEND); As I had mentioned before, this function was planned to be removed. tglx has now pulled in the patch into tip/core[1]. If this patch is already pulled in, it's better to revert so that it won't break the build in linux-next. Since the flags are now moved to GIC driver, this patch is no longer required. Sorry for the trouble. Regards, Sudeep [1] https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=irq/core&id=0d3f2c92e004c67404fabea19728c1962b777bd6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/