Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752750AbbG0LLS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jul 2015 07:11:18 -0400
Received: from www.linutronix.de ([62.245.132.108]:56306 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752407AbbG0LLO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jul 2015 07:11:14 -0400
Date: Mon, 27 Jul 2015 13:10:55 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
cc: =?ISO-8859-15?Q?Philip_M=FCller?= <philm@manjaro.org>,
        linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
        Guenter Roeck <linux@roeck-us.net>, manjaro-dev@manjaro.org,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH] cpu/cacheinfo: Fix teardown path
In-Reply-To: <20150727075805.GA20416@nazgul.tnic>
Message-ID: <alpine.DEB.2.11.1507271310230.9867@nanos>
References: <55B16967.1040609@manjaro.org> <55B47BB8.6080202@manjaro.org> <20150727075805.GA20416@nazgul.tnic>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-2115282835-1437995456=:9867"
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2413
Lines: 64

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2115282835-1437995456=:9867
Content-Type: TEXT/PLAIN; charset=utf-8
Content-Transfer-Encoding: 8BIT



On Mon, 27 Jul 2015, Borislav Petkov wrote:

> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 27 Jul 2015 08:36:27 +0200
> Subject: [PATCH] cpu/cacheinfo: Fix teardown path
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Philip Müller reported a hang when booting 32-bit 4.1 kernel on an AMD
> box. A fragment of the splat was enough to pinpoint the issue:
> 
>   task: f58e0000 ti: f58e8000 task.ti: f58e800
>   EIP: 0060:[<c135a903>] EFLAGS: 00010206 CPU: 0
>   EIP is at free_cache_attributes+0x83/0xd0
>   EAX: 00000001 EBX: f589d46c ECX: 00000090 EDX: 360c2000
>   ESI: 00000000 EDI: c1724a80 EBP: f58e9ec0 ESP: f58e9ea0
>    DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
>   CR0: 8005003b CR2: 000000ac CR3: 01731000 CR4: 000006d0
> 
> cache_shared_cpu_map_setup() did check sibling CPUs cacheinfo descriptor
> while the respective teardown path cache_shared_cpu_map_remove() didn't.
> Fix that.
> 
> >From tglx's version: to be on the safe side, move the cacheinfo
> descriptor check to free_cache_attributes(), thus cleaning up the
> hotplug path a little and making this even more robust.
> 
> Reported-by: Philip Müller <philm@manjaro.org>
> Cc: <stable@vger.kernel.org> # 4.1
> Cc: Andre Przywara <andre.przywara@arm.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: manjaro-dev@manjaro.org
> Cc: Philip Müller <philm@manjaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lkml.kernel.org/r/55B47BB8.6080202@manjaro.org
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> 
> Moin Thomas,
> 
> I've merged both patches and tagged it for stable. Which means,
> tip-urgent.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
--8323329-2115282835-1437995456=:9867--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/