Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbbG0L0V (ORCPT ); Mon, 27 Jul 2015 07:26:21 -0400 Received: from foss.arm.com ([217.140.101.70]:52484 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbG0L0S (ORCPT ); Mon, 27 Jul 2015 07:26:18 -0400 Date: Mon, 27 Jul 2015 12:25:47 +0100 From: Mark Rutland To: Haibo Chen Cc: "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" , "dmitry.torokhov@gmail.com" , "hans.verkuil@cisco.com" , "hadess@hadess.net" , "mchehab@osg.samsung.com" , "mamlinav@gmail.com" , "arnd@arndb.de" , "jonathar@broadcom.com" , "hdegoede@redhat.com" , "christian.gmeiner@gmail.com" , "scott.liu@emc.com.tw" , "geert@linux-m68k.org" , "benjamin.tissoires@redhat.com" , "sebastien.szymanski@armadeus.com" , "sbranden@broadcom.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-input@vger.kernel.org" Subject: Re: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Message-ID: <20150727112547.GE9169@leverpostej> References: <1437996407-27266-1-git-send-email-haibo.chen@freescale.com> <1437996407-27266-3-git-send-email-haibo.chen@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437996407-27266-3-git-send-email-haibo.chen@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 43 On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote: > Here we apply required documentation for the imx6ul touch screen > controller driver which describe available properties and how to > use them. > > Signed-off-by: Haibo Chen > --- > .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > new file mode 100644 > index 0000000..e34d752 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > @@ -0,0 +1,14 @@ > +* Freescale i.MX6UL Touch Controller > + > +Required properties: > +- compatible: must be "fsl,imx6ul-tsc" > + What about all the other properties in the example? > +Example: > + &tsc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_tsc>; > + status = "okay"; > + xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>; > + measure_delay_time = <0xfff>; > + pre_charge_time = <0xffff>; Thiose underscores should be dashes, and all the properties should be documented. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/