Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753317AbbG0MyX (ORCPT ); Mon, 27 Jul 2015 08:54:23 -0400 Received: from mail-bn1bn0103.outbound.protection.outlook.com ([157.56.110.103]:39552 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752650AbbG0MyL convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2015 08:54:11 -0400 From: Madalin-Cristian Bucur To: David Miller CC: "joe@perches.com" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Liberman Igal , "ppc@mindchasers.com" , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" Subject: RE: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds Thread-Topic: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds Thread-Index: AQHQxJn/ayRE53kbD0+lkRb1eflMup3nw6cAgAMAN4CAA6pmAIAA2pkg Date: Mon, 27 Jul 2015 12:54:09 +0000 Message-ID: References: <1437581806-17420-3-git-send-email-madalin.bucur@freescale.com> <1437587228.20787.26.camel@perches.com> <20150726.163520.846046458508685868.davem@davemloft.net> In-Reply-To: <20150726.163520.846046458508685868.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.166.1] x-microsoft-exchange-diagnostics: 1;BL2PR03MB499;5:hHPg1e/4GWAl0YcuRIcY2ib5UW4Clb2hyeCvDc4N8OxubmYU9V7PM6McMhhJjWGbMdJP+DUf+T36pXrTDV8JNlrGM5VxPaRmdR9vaf/mcHrYRcmoghIW4sOivoWmQGSpXBGqJxr93zPYO1XNjRCIdA==;24:+XRpSElkza/HJBmO67N7K++UMJKS8kV9S1jgP8SrpWdDeo/zrWO9aP7FFJgG6nqMQg2tHdS3momud8WFwQ0pV0D10aDCzNpTTwZFbz3BSGQ=;20:Yd9MigACtFYipnlPN05U5sW7u676LEdp1S2YtIAv/BlTdzd2QYpvwVy7FI3B56l2ggha7MdRMFCYjIkOj8jUDQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB499; bl2pr03mb499: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BL2PR03MB499;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB499; x-forefront-prvs: 0650714AAA x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(377424004)(24454002)(122556002)(40100003)(102836002)(5002640100001)(86362001)(77096005)(189998001)(62966003)(2900100001)(2950100001)(92566002)(74316001)(19580405001)(33656002)(54356999)(50986999)(5003600100002)(110136002)(19580395003)(76176999)(106116001)(77156002)(2656002)(93886004)(87936001)(76576001)(66066001)(46102003)(99286002)(5001960100002)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB499;H:BL2PR03MB545.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2015 12:54:09.0670 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB499 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 43 > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Monday, July 27, 2015 2:35 AM > To: Bucur Madalin-Cristian-B32716 > Cc: joe@perches.com; netdev@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Wood Scott-B07421; > Liberman Igal-B31950; ppc@mindchasers.com; pebolle@tiscali.nl; > joakim.tjernlund@transmode.se > Subject: Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds > > From: Madalin-Cristian Bucur > Date: Fri, 24 Jul 2015 15:49:39 +0000 > > >> -----Original Message----- > >> From: Joe Perches [mailto:joe@perches.com] > >> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: > >> > Allow the user to tweak the refill threshold and the total number > >> > of buffers in the buffer pool. The provided values are for one CPU. > >> > >> Any value in making these module parameters instead? > > > > I expect one would (hardly ever) change these to improve some corner > > cases then use them with the new values. It may help in the tuning process > > but afterwards the bloat to the bootcmd would probably be a nuisance. > > I think these should be controlled by the existing ethtool infrastructure. > > Neither the Kconfig mechanism nor module parameters are appropriate, at > all. The existing ethtool options are for ring based drivers (ethtool -g / -G). I would not use those as we are not using rings (they do not map well anyway). We could introduce special options for our non-ring devices but for these parameters in particular I'd just resort to defines in the code as it's improbable one would want to change them. Madalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/