Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753424AbbG0My5 (ORCPT ); Mon, 27 Jul 2015 08:54:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38833 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbbG0My4 (ORCPT ); Mon, 27 Jul 2015 08:54:56 -0400 Subject: Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi To: public_timo.s@silentcreek.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, maxime.ripard@free-electrons.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <1437960486-2809-1-git-send-email-public_timo.s@silentcreek.de><55B5E6DB.8020009@redhat.com> <20150727123653.36C046C8007E@dd34104.kasserver.com> Cc: wens@csie.org From: Hans de Goede Message-ID: <55B62A1B.6030601@redhat.com> Date: Mon, 27 Jul 2015 14:54:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150727123653.36C046C8007E@dd34104.kasserver.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 33 Hi, On 27-07-15 14:36, public_timo.s@silentcreek.de wrote: > Hi again, > > one more thing... > > Hans de Goede schrieb am 27.07.2015 10:07: >> IMHO we should just stick with the standard operating points unless we know >> that there are stability issues with them (such as e.g. on the A10 OlinuxIno >> Lime). > > If we stick to the standard operating points, shouldn't we honor their voltages > as well? If we set the minimum voltage for dcdc2 to 1.0V (as you did) or 1.05V > (as I did), this means that the lowest operating point of 144MHz@0.9V defined > in sun7i-a20.dtsi (and with my definition the 312MHz opp as well) will not be > available because cpufreq-dt simply ignores operating points that aren't within > the set voltage range for that regulator. Ah, good point. I don't know what is the right thing todo here. ChenYu (in the CC), since you did most of the original work here, do you know why we have an op at 0.9 volt, but none of our boards allow the voltage to go that low in the regulator settings ? Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/