Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbG0NQm (ORCPT ); Mon, 27 Jul 2015 09:16:42 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:36312 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbbG0NQj convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2015 09:16:39 -0400 MIME-Version: 1.0 In-Reply-To: <20150723222349.GB9973@kroah.com> References: <1437510892-30376-1-git-send-email-linux@roeck-us.net> <20150723222349.GB9973@kroah.com> Date: Mon, 27 Jul 2015 15:16:38 +0200 Message-ID: Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API From: Linus Walleij To: Greg Kroah-Hartman , Niklas Cassel Cc: Guenter Roeck , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-cris-kernel@axis.com, Jesper Nilsson , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 27 On Fri, Jul 24, 2015 at 12:23 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote: >> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> makes the flags argument to devm_gpiod_get_optional mandatory but does not >> update all users. This results in the following build error. >> >> drivers/tty/serial/etraxfs-uart.c:933:16: error: >> too few arguments to function ‘devm_gpiod_get_optional’ >> >> Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") > > This patch isn't in Linus's tree, so whatever tree this commit is in, > needs to also take this fix. OK I'll take it. It's a bit messy with this breakage but it is for a good cause. Niklas: send me your patch when finished. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/