Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbbG0N3n (ORCPT ); Mon, 27 Jul 2015 09:29:43 -0400 Received: from bes.se.axis.com ([195.60.68.10]:40642 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbbG0N3l (ORCPT ); Mon, 27 Jul 2015 09:29:41 -0400 Message-ID: <55B63241.7080409@axis.com> Date: Mon, 27 Jul 2015 15:29:37 +0200 From: Niklas Cassel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Linus Walleij , Greg Kroah-Hartman , Niklas Cassel CC: Guenter Roeck , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-cris-kernel , Jesper Nilsson , =?UTF-8?B?VXdlIEtsZWluZS1Lw7Zu?= =?UTF-8?B?aWc=?= Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API References: <1437510892-30376-1-git-send-email-linux@roeck-us.net> <20150723222349.GB9973@kroah.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 37 On 07/27/2015 03:16 PM, Linus Walleij wrote: > On Fri, Jul 24, 2015 at 12:23 AM, Greg Kroah-Hartman > wrote: >> On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote: >>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >>> makes the flags argument to devm_gpiod_get_optional mandatory but does not >>> update all users. This results in the following build error. >>> >>> drivers/tty/serial/etraxfs-uart.c:933:16: error: >>> too few arguments to function ‘devm_gpiod_get_optional’ >>> >>> Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") >> >> This patch isn't in Linus's tree, so whatever tree this commit is in, >> needs to also take this fix. > > OK I'll take it. It's a bit messy with this breakage but it is for > a good cause. > > Niklas: send me your patch when finished. I've already sent them to the linux-serial and linux-kernel mailing lists. I'm sorry that I didn't think of CC:ing you Linus. It might be better if you take them, since you got the devm_gpiod_get_optional patches in your tree. http://marc.info/?l=linux-serial&m=143778406314867 http://marc.info/?l=linux-serial&m=143778407714871 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/