Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbbG0No4 (ORCPT ); Mon, 27 Jul 2015 09:44:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42629 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbbG0Nox (ORCPT ); Mon, 27 Jul 2015 09:44:53 -0400 Date: Mon, 27 Jul 2015 09:44:53 -0400 From: Vivek Goyal To: Minfei Huang Cc: ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Minfei Huang Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150727134453.GA16064@redhat.com> References: <1433571252-11874-1-git-send-email-mhuang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433571252-11874-1-git-send-email-mhuang@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 44 On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: > From: Minfei Huang > > Transforming PFN(Page Frame Number) to struct page is never failure, so > we can simplify the code logic to do the image->control_page assignment > directly in the loop, and remove the unnecessary conditional judgement. > > Signed-off-by: Minfei Huang Looks good to me. Acked-by: Vivek Goyal Thanks Vivek > --- > kernel/kexec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 7a36fdc..4589899 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > /* If I don't overlap any segments I have found my hole! */ > if (i == image->nr_segments) { > pages = pfn_to_page(hole_start >> PAGE_SHIFT); > + image->control_page = hole_end; > break; > } > } > - if (pages) > - image->control_page = hole_end; > > return pages; > } > -- > 2.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/