Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbbG0NSR (ORCPT ); Mon, 27 Jul 2015 09:18:17 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:63180 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752533AbbG0NSQ (ORCPT ); Mon, 27 Jul 2015 09:18:16 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: "Rafael J. Wysocki" , Linux PM list , Linux Kernel Mailing List , Russell King Subject: Re: [PATCH v2] cpufreq: Avoid attempts to create duplicate symbolic links Date: Mon, 27 Jul 2015 15:45:10 +0200 Message-ID: <4080510.IQ60sVQvbL@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150727022718.GE19944@linux> References: <1660815.CyKx9SEI9c@vostro.rjw.lan> <20150727022718.GE19944@linux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 34 On Monday, July 27, 2015 07:57:18 AM Viresh Kumar wrote: > On 26-07-15, 00:46, Rafael J. Wysocki wrote: > > OK, I'll prepare a new version of that patch then, but as I said this > > choice means that we'll be creating the links to the policy at the > > policy creation time going forward. > > Atleast for the rc fix, we should do exactly this. Right. > > But we can rethink about getting both my earlier patches merged for > 4.3, which did this: > > - Keep adding CPUs to a global mask, which didn't had a existing > policy and were offline when subsys-callback for called for them. > - And then create the links only when the subsys callback is called > for CPUs, for which policy already exist, as Russell suggested. Say the subsys add callback runs for a CPU and it doesn't have a policy. If it is offline, we ignore it and the add callback won't be executed for it again. In turn, if it is online, we create a policy for it and we should (right away) link the policy to all of the CPUs that were offline when the subsys add callback was called for them. That's what we do today. Is there anything missing in that? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/