Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbbG0OB3 (ORCPT ); Mon, 27 Jul 2015 10:01:29 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:53578 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbbG0OB0 (ORCPT ); Mon, 27 Jul 2015 10:01:26 -0400 From: Govindraj Raja To: , , "Daniel Lezcano" , CC: Thomas Gleixner , Andrew Bresticker , James Hartley , "Govindraj Raja" , Damien Horsley , James Hogan , Ezequiel Garcia , Ezequiel Garcia Subject: [PATCH v4 2/7] clocksource: mips-gic: Add missing error returns checks Date: Mon, 27 Jul 2015 15:00:13 +0100 Message-ID: <1438005618-27003-3-git-send-email-govindraj.raja@imgtec.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1438005618-27003-1-git-send-email-govindraj.raja@imgtec.com> References: <1438005618-27003-1-git-send-email-govindraj.raja@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.167.141] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 64 From: Ezequiel Garcia This commit adds the required checks on the functions that return an error. Some of them are not critical, so only a warning is printed. Reviewed-by: Andrew Bresticker Signed-off-by: Ezequiel Garcia --- drivers/clocksource/mips-gic-timer.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c index 913585d..c4352f0 100644 --- a/drivers/clocksource/mips-gic-timer.c +++ b/drivers/clocksource/mips-gic-timer.c @@ -100,12 +100,18 @@ static struct notifier_block gic_cpu_nb = { static int gic_clockevent_init(void) { + int ret; + if (!cpu_has_counter || !gic_frequency) return -ENXIO; - setup_percpu_irq(gic_timer_irq, &gic_compare_irqaction); + ret = setup_percpu_irq(gic_timer_irq, &gic_compare_irqaction); + if (ret < 0) + return ret; - register_cpu_notifier(&gic_cpu_nb); + ret = register_cpu_notifier(&gic_cpu_nb); + if (ret < 0) + pr_warn("GIC: Unable to register CPU notifier\n"); gic_clockevent_cpu_init(this_cpu_ptr(&gic_clockevent_device)); @@ -125,13 +131,17 @@ static struct clocksource gic_clocksource = { static void __init __gic_clocksource_init(void) { + int ret; + /* Set clocksource mask. */ gic_clocksource.mask = CLOCKSOURCE_MASK(gic_get_count_width()); /* Calculate a somewhat reasonable rating value. */ gic_clocksource.rating = 200 + gic_frequency / 10000000; - clocksource_register_hz(&gic_clocksource, gic_frequency); + ret = clocksource_register_hz(&gic_clocksource, gic_frequency); + if (ret < 0) + pr_warn("GIC: Unable to register clocksource\n"); gic_clockevent_init(); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/