Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753693AbbG0OYQ (ORCPT ); Mon, 27 Jul 2015 10:24:16 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:53633 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbG0OYM (ORCPT ); Mon, 27 Jul 2015 10:24:12 -0400 Message-ID: <55B63F09.4030101@roeck-us.net> Date: Mon, 27 Jul 2015 07:24:09 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Matt Fleming CC: Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Jean Delvare , Wolfram Sang , Matt Fleming , Peter Tyser , Samuel Ortiz , Lee Jones Subject: Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data References: <1438004292-16382-1-git-send-email-matt@codeblueprint.co.uk> <1438004292-16382-2-git-send-email-matt@codeblueprint.co.uk> <55B636D4.6020709@roeck-us.net> <20150727141948.GA2677@codeblueprint.co.uk> In-Reply-To: <20150727141948.GA2677@codeblueprint.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 18 On 07/27/2015 07:19 AM, Matt Fleming wrote: > On Mon, 27 Jul, at 06:49:08AM, Guenter Roeck wrote: >> >> I don't see the platform data freed anywhere, neither in the error path nor >> in the cleanup path of this driver. Can you use devm_kzalloc() ? >> Otherwise I think you'll need a cleanup path. > > Oops, good catch. Yes, devm_kzalloc() can be used here, thanks! > Or maybe just use a static data structure, like in the i2c driver. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/