Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbbG0Ofk (ORCPT ); Mon, 27 Jul 2015 10:35:40 -0400 Received: from mail.kernel.org ([198.145.29.136]:49494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbG0Ofj (ORCPT ); Mon, 27 Jul 2015 10:35:39 -0400 Date: Mon, 27 Jul 2015 22:35:15 +0800 From: Shawn Guo To: Shenwei Wang Cc: "jason@lakedaemon.net" , Huang Anson , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "shawn.guo@linaro.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Message-ID: <20150727143515.GQ12927@tiger> References: <1437584859-64203-1-git-send-email-shenwei.wang@freescale.com> <1437584859-64203-2-git-send-email-shenwei.wang@freescale.com> <20150727134058.GL12927@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 36 On Mon, Jul 27, 2015 at 02:13:37PM +0000, Shenwei Wang wrote: > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: 2015年7月27日 8:41 > > To: Wang Shenwei-B38339 > > Cc: shawn.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net; Huang > > Yongcai-B20788; linux-kernel@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > > sources > > > > On Wed, Jul 22, 2015 at 12:07:38PM -0500, Shenwei Wang wrote: > > > diff --git a/include/soc/imx/gpcv2.h b/include/soc/imx/gpcv2.h new > > > file mode 100644 index 0000000..73d6e75 > > > --- /dev/null > > > +++ b/include/soc/imx/gpcv2.h > > > > I do not like this header, which couples imx7d irqchip and pm driver so > > much. Can you please elaborate why we have to have this header? > > PM driver does depend on the irqchip driver. It needs some input like enabled irqs and > wakeup irqs to decide which module to be powered off in low power states. I am also > considering if the header file could be removed or not. So far it seems a common place > to define a structure which is used in both drivers is still required. Please be more specific. Trimming the header down to the macros and structures/fields that are necessary to be in the header might be a good idea. And then we can go through them one by one to see if there is a way to avoid them being in the header. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/