Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbbG0Pjl (ORCPT ); Mon, 27 Jul 2015 11:39:41 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:48017 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbG0Pjj (ORCPT ); Mon, 27 Jul 2015 11:39:39 -0400 Date: Mon, 27 Jul 2015 11:39:00 -0400 From: Johannes Weiner To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , David Rientjes , Greg Thelen , "Aneesh Kumar K.V" , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Naoya Horiguchi Subject: Re: [RFC v2 1/4] mm: make alloc_pages_exact_node pass __GFP_THISNODE Message-ID: <20150727153900.GA31432@cmpxchg.org> References: <1437749126-25867-1-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437749126-25867-1-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 33 On Fri, Jul 24, 2015 at 04:45:23PM +0200, Vlastimil Babka wrote: > @@ -310,11 +326,18 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask, > return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask)); > } > > +/* > + * Allocate pages, restricting the allocation to the node given as nid. The > + * node must be valid and online. This is achieved by adding __GFP_THISNODE > + * to gfp_mask. > + */ > static inline struct page *alloc_pages_exact_node(int nid, gfp_t gfp_mask, > unsigned int order) > { > VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES || !node_online(nid)); > > + gfp_mask |= __GFP_THISNODE; > + > return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask)); > } The "exact" name is currently ambiguous within the allocator API, and it's bad that we have _exact_node() and _exact_nid() with entirely different meanings. It'd be good to make "thisnode" refer to specific and exclusive node requests, and "exact" to mean page allocation chunks that are not in powers of two. Would you consider renaming this function to alloc_pages_thisnode() as part of this series? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/