Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753626AbbG0PsG (ORCPT ); Mon, 27 Jul 2015 11:48:06 -0400 Received: from mga09.intel.com ([134.134.136.24]:52431 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbG0PsD (ORCPT ); Mon, 27 Jul 2015 11:48:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,554,1432623600"; d="scan'208";a="770699650" Message-ID: <1438011952.29746.93.camel@linux.intel.com> Subject: Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data From: Andy Shevchenko To: Lee Jones , Matt Fleming Cc: Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Mika Westerberg , Jean Delvare , Wolfram Sang , Matt Fleming , Peter Tyser , Samuel Ortiz Date: Mon, 27 Jul 2015 18:45:52 +0300 In-Reply-To: <20150727153344.GC21114@x1> References: <1438004292-16382-1-git-send-email-matt@codeblueprint.co.uk> <1438004292-16382-2-git-send-email-matt@codeblueprint.co.uk> <20150727153344.GC21114@x1> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2175 Lines: 62 On Mon, 2015-07-27 at 16:33 +0100, Lee Jones wrote: > On Mon, 27 Jul 2015, Matt Fleming wrote: > > > From: Matt Fleming > > > > Intel Sunrisepoint (Skylake PCH) has the iTCO watchdog accessible > > across > > the SMBus, unlike previous generations of PCH/ICH where it was on > > the > > LPC bus. Because it's on the SMBus, it doesn't make sense to pass > > around > > a 'struct lpc_ich_info', and leaking the type of bus into the iTCO > > watchdog driver is kind of backwards anyway. > > > > This change introduces a new 'struct iTCO_wdt_platform_data' for > > use > > inside the iTCO watchdog driver and by the upcoming Intel > > Sunrisepoint > > code, which neatly avoids having to include lpc_ich headers in the > > i801 > > i2c driver. > > > > A simple translation layer is provided for converting from the > > existing > > 'struct lpc_ich_info' inside the lpc_ich mfd driver. > > Is this patch related to Andy's patch-set? No, it's a separate stuff. They are pretty independent as I can see. > > https://lkml.org/lkml/2015/7/27/599 > > > Cc: Peter Tyser > > Cc: Samuel Ortiz > > Cc: Lee Jones > > Cc: Wim Van Sebroeck > > Signed-off-by: Matt Fleming > > --- > > drivers/mfd/lpc_ich.c | 32 > > +++++++++++++++++++++++++++++--- > > drivers/watchdog/Kconfig | 2 +- > > drivers/watchdog/iTCO_wdt.c | 11 +++++------ > > include/linux/mfd/lpc_ich.h | 6 ------ > > include/linux/platform_data/iTCO_wdt.h | 18 ++++++++++++++++++ > > 5 files changed, 53 insertions(+), 16 deletions(-) > > create mode 100644 include/linux/platform_data/iTCO_wdt.h > > How are all of these changes related? > > Why do they all have to be in a single patch? > -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/