Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220AbbG0Puz (ORCPT ); Mon, 27 Jul 2015 11:50:55 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:35105 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbbG0Pux (ORCPT ); Mon, 27 Jul 2015 11:50:53 -0400 Message-ID: <55B65318.6070308@atmel.com> Date: Mon, 27 Jul 2015 17:49:44 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Rob Herring , Tomi Valkeinen CC: , , Jean-Christophe Plagniol-Villard Subject: Re: [PATCH] video: fbdev: atmel: fix warning for const return value References: <1438011701-18423-1-git-send-email-robh@kernel.org> In-Reply-To: <1438011701-18423-1-git-send-email-robh@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 47 Le 27/07/2015 17:41, Rob Herring a ?crit : > A const on a return value is meaningless and generates a warning on some > versions of gcc: > > drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type > > This was found on 0-day with avr32 builds with CONFIG_OF enabled, but > it doesn't seem to generate warnings for other arches. > > Reported-by: Fengguang Wu > Signed-off-by: Rob Herring > Cc: Nicolas Ferre Sure: Acked-by: Nicolas Ferre Thanks Rob! > Cc: Jean-Christophe Plagniol-Villard > Cc: Tomi Valkeinen > --- > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > index abadc49..66f4b70 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { > [ATMEL_LCDC_WIRING_RGB] = "RGB", > }; > > -const int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) > +int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) > { > const char *mode; > int err, i; > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/