Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754540AbbG0QFc (ORCPT ); Mon, 27 Jul 2015 12:05:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:35795 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753801AbbG0QF3 (ORCPT ); Mon, 27 Jul 2015 12:05:29 -0400 Date: Mon, 27 Jul 2015 17:05:25 +0100 From: Mel Gorman To: Chris Metcalf Cc: Andrew Morton , Yasuaki Ishimatsu , Pekka Enberg , Paul McQuade , Tang Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] bootmem: avoid freeing to bootmem after bootmem is done Message-ID: <20150727160525.GQ2561@suse.de> References: <20150727105951.GO2561@suse.de> <1438011366-11474-1-git-send-email-cmetcalf@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1438011366-11474-1-git-send-email-cmetcalf@ezchip.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 23 On Mon, Jul 27, 2015 at 11:36:06AM -0400, Chris Metcalf wrote: > Bootmem isn't popular any more, but some architectures still use it, > and freeing to bootmem after calling free_all_bootmem_core() can end > up scribbling over random memory. Instead, make sure the kernel > generates a warning in this case by ensuring the node_bootmem_map > field is non-NULL when are freeing or marking bootmem. > > An instance of this bug was just fixed in the tile architecture > ("tile: use free_bootmem_late() for initrd") and catching this case > more widely seems like a good thing. > > Signed-off-by: Chris Metcalf Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/