Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbG0RLU (ORCPT ); Mon, 27 Jul 2015 13:11:20 -0400 Received: from mga11.intel.com ([192.55.52.93]:58310 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbbG0RLT convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2015 13:11:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,555,1432623600"; d="scan'208";a="736540061" From: "Liang, Kan" To: Jiri Olsa CC: "a.p.zijlstra@chello.nl" , "acme@kernel.org" , "luto@kernel.org" , "mingo@redhat.com" , "eranian@google.com" , "ak@linux.intel.com" , "mark.rutland@arm.com" , "Hunter, Adrian" , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Thread-Topic: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Thread-Index: AQHQxlQ55LgR0xFrwkOv+h4nJQMiWJ3tbj2AgAIjCnA= Date: Mon, 27 Jul 2015 17:11:13 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077018CCDD2@SHSMSX103.ccr.corp.intel.com> References: <1437745712-16649-1-git-send-email-kan.liang@intel.com> <1437745712-16649-6-git-send-email-kan.liang@intel.com> <20150726163121.GC24646@krava.brq.redhat.com> In-Reply-To: <20150726163121.GC24646@krava.brq.redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 38 > > On Fri, Jul 24, 2015 at 09:48:31AM -0400, kan.liang@intel.com wrote: > > SNIP > > > struct addr_location *al, > > @@ -109,6 +110,7 @@ struct hist_entry *__hists__add_entry(struct > hists *hists, > > struct branch_info *bi, > > struct mem_info *mi, u64 period, > > u64 weight, u64 transaction, > > + struct freq_perf_info *freq_perf, > > bool sample_self); > > int hist_entry_iter__add(struct hist_entry_iter *iter, struct > addr_location *al, > > int max_stack_depth, void *arg); > > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index > > e97cd47..90422ed 100644 > > --- a/tools/perf/util/sort.h > > +++ b/tools/perf/util/sort.h > > @@ -54,6 +54,9 @@ struct he_stat { > > u64 period_guest_us; > > u64 weight; > > u32 nr_events; > > + u64 freq; > > + u64 cpu_u; > > could the cpu_u have more descriptive name? How about "cpu_util" or "cpu_utilization"? Thanks, Kan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/