Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754254AbbG0RWl (ORCPT ); Mon, 27 Jul 2015 13:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754163AbbG0RWj (ORCPT ); Mon, 27 Jul 2015 13:22:39 -0400 Date: Mon, 27 Jul 2015 19:16:18 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: "a.p.zijlstra@chello.nl" , "acme@kernel.org" , "luto@kernel.org" , "mingo@redhat.com" , "eranian@google.com" , "ak@linux.intel.com" , "mark.rutland@arm.com" , "Hunter, Adrian" , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Message-ID: <20150727171618.GB20509@krava.brq.redhat.com> References: <1437745712-16649-1-git-send-email-kan.liang@intel.com> <1437745712-16649-6-git-send-email-kan.liang@intel.com> <20150726163121.GC24646@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018CCDD2@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018CCDD2@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 41 On Mon, Jul 27, 2015 at 05:11:13PM +0000, Liang, Kan wrote: > > > > On Fri, Jul 24, 2015 at 09:48:31AM -0400, kan.liang@intel.com wrote: > > > > SNIP > > > > > struct addr_location *al, > > > @@ -109,6 +110,7 @@ struct hist_entry *__hists__add_entry(struct > > hists *hists, > > > struct branch_info *bi, > > > struct mem_info *mi, u64 period, > > > u64 weight, u64 transaction, > > > + struct freq_perf_info *freq_perf, > > > bool sample_self); > > > int hist_entry_iter__add(struct hist_entry_iter *iter, struct > > addr_location *al, > > > int max_stack_depth, void *arg); > > > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index > > > e97cd47..90422ed 100644 > > > --- a/tools/perf/util/sort.h > > > +++ b/tools/perf/util/sort.h > > > @@ -54,6 +54,9 @@ struct he_stat { > > > u64 period_guest_us; > > > u64 weight; > > > u32 nr_events; > > > + u64 freq; > > > + u64 cpu_u; > > > > could the cpu_u have more descriptive name? > > How about "cpu_util" or "cpu_utilization"? cpu_util sounds good to me thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/